This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
fixing issue 1632 #1633
Merged
fixing issue 1632 #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1633 +/- ##
============================================
- Coverage 35.25% 35.24% -0.02%
Complexity 1121 1121
============================================
Files 186 186
Lines 10178 10181 +3
Branches 1656 1657 +1
============================================
Hits 3588 3588
- Misses 6169 6172 +3
Partials 421 421 |
Codecov Report
@@ Coverage Diff @@
## master #1633 +/- ##
============================================
+ Coverage 34.82% 35.24% +0.41%
+ Complexity 1122 1120 -2
============================================
Files 186 186
Lines 10309 10178 -131
Branches 1679 1656 -23
============================================
- Hits 3590 3587 -3
+ Misses 6297 6171 -126
+ Partials 422 420 -2 |
rohanKanojia
requested review from
devang-gaur,
rohanKanojia and
lordofthejars
and removed request for
devang-gaur
| * @param defaultValue | ||
| * @return | ||
| */ | ||
| private String getImagePullPolicy(ResourceConfig resourceConfig, String defaultValue) { |
There was a problem hiding this comment.
I would suggest moving this function to it's parent class i.e BaseEnricher since both DefaultControllerEnricher and ControllerViaPluginConfiguration are using this method
rohanKanojia
suggested changes
May 13, 2019
devang-gaur
suggested changes
May 15, 2019
There was a problem hiding this comment.
@theexplorist better to shift getImagePullPolicy( ) to the base class
devang-gaur
approved these changes
May 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1632