This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
Added ingress support for fabric8:resource #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordofthejars
approved these changes
May 6, 2019
rohanKanojia
reviewed
May 6, 2019
plugin/src/main/resources/META-INF/fabric8/profiles-default.yml
Outdated
Show resolved
Hide resolved
devang-gaur
force-pushed
the
ingress_enricher
branch
from
3e7a387 to
50e5d24
Compare
devang-gaur
force-pushed
the
ingress_enricher
branch
from
50e5d24 to
dc5b213
Compare
rohanKanojia
approved these changes
Jun 3, 2019
|
@dev-gaur : Were you able to test it properly on your minikube setup? Is it still a WIP? |
| @@ -91,6 +92,8 @@ | |||
| @Parameter | |||
| private List<ServiceAccountConfig> serviceAccounts; | |||
|
|
|||
| private List<IngressRule> ingressRules; | |||
There was a problem hiding this comment.
@dev-gaur : Why are you using a kuberenetes model class instead of a custom config class used in other xml config resources here?
rohanKanojia
pushed a commit
that referenced
this pull request
Oct 10, 2019
rohanKanojia
pushed a commit
that referenced
this pull request
Oct 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WIP as I've not been able to test ingress properly on my minikube setup