Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

update vmp groupid and vert.x version #1517

Merged
merged 5 commits into from
Feb 18, 2019
Merged

Conversation

rdruss
Copy link
Contributor

@rdruss rdruss commented Feb 7, 2019

No description provided.

@rohanKanojia rohanKanojia requested review from lordofthejars, rhuss and devang-gaur and removed request for lordofthejars February 8, 2019 05:48
@rohanKanojia rohanKanojia added the pr/changelog-entry-please Please add a changelog entry for this PR label Feb 8, 2019
Copy link
Contributor

@lordofthejars lordofthejars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor thing, can you update the CHANGELOG.md file with this change?

@rdruss
Copy link
Contributor Author

rdruss commented Feb 11, 2019

I'll get that in today

@rohanKanojia rohanKanojia removed the pr/changelog-entry-please Please add a changelog entry for this PR label Feb 12, 2019
@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #1517 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1517      +/-   ##
============================================
+ Coverage        35%   35.08%   +0.08%     
- Complexity     1088     1089       +1     
============================================
  Files           180      180              
  Lines          9973     9970       -3     
  Branches       1655     1654       -1     
============================================
+ Hits           3491     3498       +7     
+ Misses         6066     6057       -9     
+ Partials        416      415       -1

@rohanKanojia rohanKanojia merged commit 96f17eb into fabric8io:master Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants