Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Fix #1299 : autotls feature doesn't work with OpenShift 3.9 (Kubernetes 1.8+) due to InitContainer annotation deprecation #1318

Merged
merged 3 commits into from
Jul 30, 2018
Merged

Fix #1299 : autotls feature doesn't work with OpenShift 3.9 (Kubernetes 1.8+) due to InitContainer annotation deprecation #1318

merged 3 commits into from
Jul 30, 2018

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia
Copy link
Member Author

rohanKanojia commented Jul 17, 2018 •
edited
Loading

@nicolaferraro @hrishin : Could you please review? It's a tiny PR ;)

nicolaferraro
nicolaferraro suggested changes Jul 17, 2018
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the annotation didn't change name, but they've removed the annotation in favor of the field in the PodSpec. So you should set the initContainers field in the handler..

@nicolaferraro
Copy link
Member

https://kubernetes.io/docs/concepts/workloads/pods/init-containers#support-and-compatibility

nicolaferraro
nicolaferraro approved these changes Jul 18, 2018
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@rhuss
Copy link
Contributor

rhuss commented Jul 18, 2018

retest this

@rohanKanojia
Fix fabric8io#1299 : autotls feature doesn't work with OpenShift 3.9 …
49cb572 
…(Kubernetes 1.8+) due to InitContainer annotation deprecation
@rohanKanojia rohanKanojia added the target/3.5 PR targeted to 3.5 label Jul 24, 2018
@rohanKanojia
Copy link
Member Author

@rhuss : All checks have passed. Could you please take a look and approve so that we can proceed with merging?

@rhuss
Copy link
Contributor

rhuss commented Jul 24, 2018

I think its ok when 1 reviewer (@nicolaferraro) approved it. So going to merge it now.

rhuss
rhuss approved these changes Jul 24, 2018
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rhuss
Copy link
Contributor

rhuss commented Jul 30, 2018

Going to merge as the test fails because of the boosters (not part of this project) are failing. Hopefully we get #1317 fixed.

@rhuss rhuss merged commit ee34d14 into fabric8io:master Jul 30, 2018
@rohanKanojia rohanKanojia mentioned this pull request Dec 21, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@piyush-garg piyush-garg piyush-garg approved these changes

@oscerd oscerd oscerd approved these changes

@nicolaferraro nicolaferraro nicolaferraro approved these changes

@rhuss rhuss rhuss approved these changes

@hrishin hrishin Awaiting requested review from hrishin

Assignees

@rohanKanojia rohanKanojia

Labels
target/3.5 PR targeted to 3.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rohanKanojia @nicolaferraro @rhuss @oscerd @piyush-garg