Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Move the MetadataEnricher to standard enrichers #828

Closed
nicolaferraro opened this issue Feb 14, 2017 · 2 comments
Closed

Move the MetadataEnricher to standard enrichers #828

nicolaferraro opened this issue Feb 14, 2017 · 2 comments
Assignees
Labels
cat/techdebt Technical debt, like missing unit tests or tests

Comments

@nicolaferraro
Copy link
Member

We should move the code that adds selectors and labels to the generated resources from EnricherManager to a specific standard MetadataEnricher.

@nicolaferraro nicolaferraro self-assigned this Feb 14, 2017
@rhuss rhuss removed the FITG label Jul 23, 2018
@rhuss rhuss added cat/techdebt Technical debt, like missing unit tests or tests and removed cat/techdebt Technical debt, like missing unit tests or tests cat/refactoring labels Sep 14, 2018
@stale
Copy link

stale bot commented Dec 13, 2018

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue/PR considered to be stale label Dec 13, 2018
@rhuss rhuss removed the status/stale Issue/PR considered to be stale label Dec 14, 2018
@rhuss rhuss added this to the Backlog milestone Dec 14, 2018
@rhuss rhuss removed this from the Backlog milestone Dec 14, 2018
@devang-gaur
Copy link
Contributor

devang-gaur commented Jan 23, 2019

@rhuss @lordofthejars @rohanKanojia @nicolaferraro I'm currently working on this issue and will send a PR soon when done.

Apart from that, I'm in a bit of dilemna about this issue - is this actually needed ? Would this be the perfect thing to do ?

As far as I understand, the code in EnricherManager that adds metadata and selector labels invokes some visitor pattern classes and the labels from enrichers such as GitEnricher , TriggerAnnotationEnricher etc are applied.

If we move that functionality into a 'MetadataEnricher' , then it will act as Meta-Enricher which facilitates for other Enrichers that have methods getAnnotations( ) , getLabels( ), getSelector( )

Do we want this kind of flow among enrichers?

Please correct me if I'm wrong.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cat/techdebt Technical debt, like missing unit tests or tests
Projects
None yet
Development

No branches or pull requests

3 participants