-
Notifications
You must be signed in to change notification settings - Fork 202
Move the MetadataEnricher to standard enrichers #828
Comments
This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions! |
@rhuss @lordofthejars @rohanKanojia @nicolaferraro I'm currently working on this issue and will send a PR soon when done. Apart from that, I'm in a bit of dilemna about this issue - is this actually needed ? Would this be the perfect thing to do ? As far as I understand, the code in EnricherManager that adds metadata and selector labels invokes some visitor pattern classes and the labels from enrichers such as GitEnricher , TriggerAnnotationEnricher etc are applied. If we move that functionality into a 'MetadataEnricher' , then it will act as Meta-Enricher which facilitates for other Enrichers that have methods getAnnotations( ) , getLabels( ), getSelector( ) Do we want this kind of flow among enrichers? Please correct me if I'm wrong. |
We should move the code that adds selectors and labels to the generated resources from
EnricherManager
to a specific standardMetadataEnricher
.The text was updated successfully, but these errors were encountered: