Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Remove resource object post-processing #802

Closed
rhuss opened this issue Feb 3, 2017 · 2 comments
Closed

Remove resource object post-processing #802

rhuss opened this issue Feb 3, 2017 · 2 comments
Assignees
Labels
cat/techdebt Technical debt, like missing unit tests or tests target/4.0 PR for targeted to 4.0.x

Comments

@rhuss
Copy link
Contributor

rhuss commented Feb 3, 2017

Currently in ResourcesMojo a lot of post processing happens with

  • Converting Kubernetes objects to OpenShift objects
  • Converting OpenShift to Kubernetes objects
  • Filtering out Kubernetes objects (for openshift.yml)
  • Filtering out OpenShift objects (for kubernetes.yml)

All of this is not only complicated and lead to a lot of special conditional cases (if instanceof ...), but also hard to debug e.g. why a certain objects exists in the generated descriptors.

It is also the natural entry point for quick hacks which quickly pleases a certain use case but is pain and harmful in the long run when other use cases (which even might not be envisioned) happens. The volume permission init container was a good example when it was implemented as a post processing step. Also, such special behaviour is not easy to disable, except with a new configuration parameter (which leads to configurtion fragmentation, blows up the mojo, needs to be documented, needs to be added to the various way to configure stuff). Adding to the configuration should be really the last option.

Instead all functional processing should go into the Enrichers. See also #678 for more details and a solution to this problem.

@rhuss rhuss added FTG labels Feb 3, 2017
@rhuss rhuss removed the FITG label Jul 23, 2018
@rhuss rhuss added target/4.0 PR for targeted to 4.0.x cat/techdebt Technical debt, like missing unit tests or tests and removed cat/techdebt Technical debt, like missing unit tests or tests cat/refactoring labels Sep 12, 2018
@rhuss rhuss self-assigned this Oct 1, 2018
@stale
Copy link

stale bot commented Dec 30, 2018

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue/PR considered to be stale label Dec 30, 2018
@rohanKanojia rohanKanojia removed the status/stale Issue/PR considered to be stale label Dec 31, 2018
@rohanKanojia rohanKanojia assigned devang-gaur and rohanKanojia and unassigned rhuss Feb 7, 2019
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Feb 11, 2019
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Feb 12, 2019
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Feb 12, 2019
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Feb 13, 2019
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Feb 13, 2019
rohanKanojia pushed a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Feb 15, 2019
* Refactor fabric8io#802: Remove resource object post processing

* Refactor resource handlers and converters
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Feb 15, 2019
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Feb 20, 2019
@rohanKanojia
Copy link
Member

Closed via #1521

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cat/techdebt Technical debt, like missing unit tests or tests target/4.0 PR for targeted to 4.0.x
Projects
None yet
Development

No branches or pull requests

3 participants