Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Add a HealthCheck Enricher for Webapps #601

Closed
jstrachan opened this issue Oct 24, 2016 · 2 comments
Closed

Add a HealthCheck Enricher for Webapps #601

jstrachan opened this issue Oct 24, 2016 · 2 comments
Assignees
Labels
cat/feature Feature request group/enricher Enricher related prio/p1 Normal priority size/l Large

Comments

@jstrachan
Copy link
Contributor

jstrachan commented Oct 24, 2016

we should generate a readiness & liveness checks OOTB for war packaging apps.

If there is a service annotation for api.service.kubernetes.io/path we could use that if no explicit happy page URL is configured in the pom.xml; otherwise we could just default to using /

apupier pushed a commit to apupier/fabric8-maven-plugin that referenced this issue Feb 20, 2018
Mention the docker.autoCreateCustomNetworks on the networks doc
@stale
Copy link

stale bot commented Oct 4, 2018

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue/PR considered to be stale label Oct 4, 2018
@rhuss rhuss changed the title add a readiness / liveness check for the war generator Add a HealthCheck Enricher for Webapps Oct 6, 2018
@stale stale bot removed the status/stale Issue/PR considered to be stale label Oct 6, 2018
@rhuss
Copy link
Contributor

rhuss commented Oct 6, 2018

the health check enricher should work in the same spirit as the enrichers we have now for Vertx, Prometheus etc.

Alternatively, the webapp generator could also add just a Docker HEALTHCHECK we already can be reused by the DockerHealthCheckEnricher

@rhuss rhuss added cat/feature Feature request prio/p1 Normal priority size/l Large group/enricher Enricher related labels Oct 6, 2018
@lordofthejars lordofthejars self-assigned this Dec 13, 2018
lordofthejars added a commit to lordofthejars/fabric8-maven-plugin that referenced this issue Dec 17, 2018
lordofthejars added a commit to lordofthejars/fabric8-maven-plugin that referenced this issue Dec 17, 2018
lordofthejars added a commit to lordofthejars/fabric8-maven-plugin that referenced this issue Jan 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cat/feature Feature request group/enricher Enricher related prio/p1 Normal priority size/l Large
Projects
None yet
Development

No branches or pull requests

3 participants