Do not add ImageChange change triggers for Docker images

[nicolaferraro]

When using a docker image without image stream for a container in Openshift (e.g. to deploy a sidecar) in the src/main/fabric8/deployment.yml file (example here), the plugin adds a triggers on ImageStreamTag change, but there's no image stream since we want to use the docker image directly.

Fragment of the generated yml.

...
    triggers:
      type: ImageChange
    - imageChangeParams:
        automatic: true
        containerNames:
        - jaeger-agent
        from:
          kind: ImageStreamTag
          name: jaeger-agent:latest

In this case the docker image is jaegertracing/jaeger-agent:latest. We should detect if a container image is a IS or a Docker image and add triggers in the first case only.

[stale]

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

[lordofthejars]

When we merge this #1202 I think this issue might easiest to implement since after that sidecars containers are clearly separated from autogenerated ones.

[aliepold]

Hello
this issue looks the same as #816.
In my comment I have implemented a small workaround:

#816 (comment)

[rohanKanojia]

Since Deployment to DeploymentConfig logic has been shifted to enrichers we can check the effective RuntimeMode and add triggers only when runtime mode is openshift(i.e s2i build is used in which we always create imagestream)