Fix #1689: HELM mode does not support parameters without value (#1713)

fabric8io · Oct 3, 2019 · 7e0bd4d · 7e0bd4d
1 parent b5cf2c7
commit 7e0bd4d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,7 @@ After this we will switch probably to real [Semantic Versioning 2.0.0](http://se
 * Fixed image config in thorntail sample
 * Fix #1697: NullpointerException when trying to apply custom resources
 * Fix #1696: fmp not setting imagestreams resourceVersion properly.
+* Fix #1689: HELM mode does not support parameters without value
 * Fix #1676: Support for latest kubernetes client
 * Fix #1699: Ability to specify object namespace in fragments 
 * Feature #1536: Java Image Builder Support

diff --git a/plugin/src/main/java/io/fabric8/maven/plugin/mojo/build/ResourceMojo.java b/plugin/src/main/java/io/fabric8/maven/plugin/mojo/build/ResourceMojo.java
@@ -696,6 +696,9 @@ private void resolveTemplateVariables(List<io.fabric8.openshift.api.model.Parame
         for (io.fabric8.openshift.api.model.Parameter parameter : parameters) {
             String from = "${" + parameter.getName() + "}";
             String to = parameter.getValue();
+            if (to == null) {
+                throw new MojoExecutionException("Missing value for HELM template parameter " + from + " in " + kubernetesYaml);
+            }
             text = text.replace(from, to);
         }
         if (!original.equals(text)) {