Refactor v3

[edewit]

Goal of this refactor is to make the library more extendable for the client. In order to do that we've introduced a way to create custom "steps". To do so one will have to extend LauncherStep and implement:

restoreModel(model: any): void 

This is used to save the state in the URL for the authentication redirects.

Usage also changes instead of 'just' adding <f8launcher one needs to add the steps like this:

  <f8launcher (onCancel)="cancel()"> <!-- can remove this if you don't want scrolling wizard layout -->
    <div class="f8launcher-container_nav">
      <f8launcher-step-indicator #stepIndicator></f8launcher-step-indicator>
    </div>
    <div class="f8launcher-container_main">
      <f8launcher-targetenvironment-createapp-step id="TargetEnvironment"> <!-- standalone reusable --> 
      </f8launcher-targetenvironment-createapp-step>
      ...
   </f8launcher>

Also new in this version is the ability to customize the 'next buttons' with a section like this:

<f8launcher>
...
  <div class="f8launcher-container_completed-footer">
    <button class="btn btn-primary btn-lg" (click)="complete()">
      View New Application
    </button>
  </div>
</f8launcher>

This will also aid in tailored user experience

BREAKING CHANGE: new client API
fixes: #369

[bartoszmajsak]

BREAKING CHANGE: new client API

@edewit can you point me to those breaking changes so we can understand as impact?

[edewit]

@bartoszmajsak instead of using <f8launcher></f8launcher> one needs to add the steps that one wants to use for an example of this have a look at the demo application. Also the API to send the data to the backend has changed there is no summary object anymore but a projectile that has to HttpParams function one can use

[ia3andy]

Could you squash or rename commits?

[edewit]

@ia3andy I'll squash on merge?

[ia3andy]

I hope I didn't miss something, but it looks good to me ^^

[vikram-raj]

targetEnviroment is used by the only standalone launcher. So, can you make as an optional attribute?

[vikram-raj]

@edewit import flow is not working for the demo app. I am getting an error that the repository does not exist.

[edewit]

@vikram-raj import is fixed with 02d640a

[edewit]

full doc is available https://hackmd.io/wR4tP6KqQZOWqM1Tk3_tUQ?view

[vikram-raj]

@edewit Don't you think we don't need this variable (nextButtons) in ngx-launcher? I introduce this varibale to handle feature flag for view pipeline and Edit Application in Web IDE button from fabric8-ui.

[edewit]

@edewit Don't you think we don't need this variable (nextButtons) in ngx-launcher? I introduce this varibale to handle feature flag for view pipeline and Edit Application in Web IDE button from fabric8-ui.

With the new setup these buttons can be handled by the client (fabric8-ui) no need to have such a switch on the ngx-launcher side

[vikram-raj]

@edewit So, can you please remove this variable?

[edewit]

@vikram-raj oops sorry I thought I did

[vikram-raj]

LGTM. Thanks, @edewit for addressing all my comments.

[fabric8cd]

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀