Skip to content
This repository has been archived by the owner on Jul 23, 2019. It is now read-only.

Refactor: Split ngx-launcher in multiple components accessible from client app #369

Closed
ia3andy opened this issue Sep 6, 2018 · 1 comment · Fixed by #379
Closed

Refactor: Split ngx-launcher in multiple components accessible from client app #369

ia3andy opened this issue Sep 6, 2018 · 1 comment · Fixed by #379

Comments

@ia3andy
Copy link
Contributor

ia3andy commented Sep 6, 2018

there are 2 different approaches:

  1. In it’s simplest form we go back to the model we had before and let ngx-launcher be a set of components / steps and each project can pick the steps that they want.

We will have as output of the ngx-launcher library:

  • one or more components for each steps
  • one component ngx-launcher that get steps as input and bind them to make a wizard

Goals:

  • Make custom steps in clients
  • Avoid having unused dependency editor in standalone launcher
  • Give control to client app on steps to use (no more if osio/launch..)
  1. More complex idea would be to, still use one component, but use a plugin architecture where we can define and load bits dynamically https://github.com/edewit/angular-plugins
@edewit edewit mentioned this issue Oct 5, 2018
edewit added a commit that referenced this issue Oct 16, 2018
Refactor to make the library more extendable for the client.

fixes: #369
BREAKING CHANGE: new client API
@fabric8cd
Copy link

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants