Partial Fix of #401: Variables & Properties with generic type parameter #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only updated for namespaces (& modules), but not interfaces, classes, root variables Variables are now transformed into Properties: Variables were already emitted as F# Properties, but their handling was different from real Properties. Now Variables are converted into Properties in `transform.fs` and can use the same print code as real Properties. Exception: Top level variables. These are printed as `let` binding, not abstract members in an interface. Add Generic Type Constraints for Variables and Properties
(Properties instead of variables -- but same issues for function properties)
Add (more) tests for multiple parameter:
Strange behaviour in F#:
`abstract v: string -> string -> string` is ok,
`abstract v: string -> string -> string` isn't, but required brackets
Further with generyc type parameter:
`abstract v: 'T -> 'T -> 'T` is ok, but (unlike with just `string`)
`abstract v: ('T -> 'T -> 'T)` is not (type parameter 'T is not defined)
Add tests for optional property:
Again strange behaviour in F#:
`abstract o: 'T option` isn't allowed, but
`abstract o: 'T option with get,set` is.
Most of these cases most likely don't occur in real code.
In the source for this issue and its tests it's not a general `'T`,
but a limitation (subset) of a string Enum
There might be cases a Variable wasn't transformed into a property. These would now fail. To prevent this Variables are now again handled in `printType` as a fallback. Additional a log message is printed to console.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles only Namespaces/Modules & Interfaces/Classes (-> interface), NOT top-level variables (->
letbinding).