Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Consul TLS #276

Closed
sethvargo opened this issue Apr 27, 2017 · 5 comments · Fixed by #602
Closed

Support Consul TLS #276

sethvargo opened this issue Apr 27, 2017 · 5 comments · Fixed by #602
Labels
theme-pki
Milestone
Unplanned

Comments

@sethvargo
Copy link

Currently only specifying the address is allowed, but there are many other options for Consul TLS like the CA file, key, and cert.
@magiconair magiconair added this to the Unplanned milestone Oct 10, 2017
jrasell added a commit to jrasell/fabio that referenced this issue Nov 20, 2017
@jrasell
Fabio can connect to Consul using TLS for secure communication.
b9d1c39 
This change updates Fabio's configuration parameters to allow use
and specification of TLS certificates for HTTPS. In Consul setups
where full TLS is configured using CA private this allows Fabio
to work in a secure manner.

Closes fabiolb#276
@jrasell jrasell mentioned this issue Nov 20, 2017
Closed
@erenfro
Copy link

erenfro commented May 22, 2018

I definitely need this as well.

@erenfro
Copy link

erenfro commented May 22, 2018

In my test environment, I had a very simple consul setup. But in my main environment where I was going to deploy fabio, consul is setup to be fully encrypting gossip and tls communications, which for fabio that means it won't work, at all.

stack72 pushed a commit to stack72/fabio that referenced this issue Jun 6, 2018
@jrasell @stack72
Fabio can connect to Consul using TLS for secure communication.
33dd7cc 
This change updates Fabio's configuration parameters to allow use
and specification of TLS certificates for HTTPS. In Consul setups
where full TLS is configured using CA private this allows Fabio
to work in a secure manner.

Closes fabiolb#276
jen20 pushed a commit to jen20/fabio that referenced this issue Jun 6, 2018
@jrasell @jen20
Fabio can connect to Consul using TLS for secure communication.
d1cab30 
This change updates Fabio's configuration parameters to allow use
and specification of TLS certificates for HTTPS. In Consul setups
where full TLS is configured using CA private this allows Fabio
to work in a secure manner.

Closes fabiolb#276
jen20 added a commit to jen20/fabio that referenced this issue Jun 6, 2018
@jen20
Merge branch 'consul-tls'
b0e0f21 
Fixes fabiolb#276, fabiolb#501 (fixes fabiolb#391)
@aaronhurt
Copy link
Member

@sethvargo Sorry if this got put to the backlog. Is this still something that's needed mainline in fabio? Sorry for asking a redundant question if this has already be covered elsewhere.

@vjeantet
Copy link

Hello, need this too, deployment compromised.

How can we help to see fabio able to connect to consul via TLS and TLS with client connect ?

@magiconair
Copy link
Contributor

@vjeantet I think the patch from @jen20 looks OK. If you can rebase that for master then we can merge it.

@sev3ryn sev3ryn mentioned this issue Feb 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theme-pki
Projects
None yet
Milestone
Unplanned
5 participants
@magiconair @sethvargo @vjeantet @erenfro @aaronhurt