-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor file cache code #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you so much for you contribution, however I added some points regarding the changes. Also because is such a small change, I recommend you to squash all commits, and follow the commit message instructions. https://github.com/faabiosr/cachego/blob/master/CONTRIBUTING.md#create-a-commit
e7163a6
to
04b2095
Compare
oh, done, i merge multiple commit to one commit. |
04b2095
to
5e4c52a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the last commented about the removed tests. Also I recommend you to rebase this PR with the latest master changes (made by you 😄 ).
5e4c52a
to
0283906
Compare
@rfyiamcool Did you rebase your branch with the latest changes? |
By the way, thanks for the great contribution @rfyiamcool ! |
what