-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated reactive dependencies #136
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package name and Maven groupId need changed or these versions cannot live side-by-side.
I’m not sure what you mean since there’s no pom.xml. I’m also not sure why the Travis build is failing, since it’s working with no issues on my end. |
The groupId is defined in the root |
Is there anything else that I may have missed? |
It looks like we may need to update the CI config to accomodate this change:
|
I’m not sure what changes to make in the yml; are you able to? |
Updated reactive dependencies (RxJava 2 -> 3, RxAndroid 2 -> 3, RxBin…ding 1 -> 4) and removed RxJava2Interop
I have a project in which I’m upgrading all the above listed libraries, and it also uses rx-preferences, which doesn’t have these libraries updated.
Compiled and installed test app, and it works on my Pixel 4.