EZP-31021: Revised exception and command messages #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
MagdalenaZuba
suggested changes
Nov 18, 2019
| @@ -75,7 +75,7 @@ public function theSelectFieldShouldBeFlaggedAsRequired() | |||
| 'required', | |||
| $nodeElement->getAttribute('required'), | |||
| sprintf( | |||
| 'select with id %s is not flagged as required', | |||
| 'The select with ID %s is not flagged as required', | |||
There was a problem hiding this comment.
This refers to a select element in a form
Co-Authored-By: MagdalenaZuba <[email protected]>
MagdalenaZuba
approved these changes
Nov 19, 2019
michalmilc90
suggested changes
Nov 19, 2019
Co-Authored-By: Michal Milc <[email protected]>
michalmilc90
approved these changes
Nov 19, 2019
webhdx
approved these changes
Nov 21, 2019
|
Please let me know when this gets merged because I have to move those changes to content-forms and admin-ui. |
DominikaK
changed the title
|
Failing tests are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EZP-31021
Main PR: ezsystems/ezpublish-kernel#2878