Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29119: Display proper validation error message when non-image file uploaded in image FieldType #239

Closed
wants to merge 1 commit into from

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Jun 13, 2018

Question Answer
Tickets https://jira.ez.no/browse/EZP-29119
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

This PR is also fixing doubled error messages (backend). See also ezsystems/ezplatform-admin-ui#507

screen shot 2018-06-13 at 3 32 22 pm

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@webhdx
Copy link
Contributor

webhdx commented Jun 14, 2018

This is a BC break for people styling their forms. Repo forms is a package that is used by external developers, we can't fix here things in AdminUI. At least we have to mind other people using it and do not introduce BC breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants