Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] EZP-29279: Values of Date Field Type should be handled in UTC only #1384

Conversation

jacek-foremski
Copy link

@jacek-foremski jacek-foremski commented Aug 17, 2018

JIRA issue: EZP-29279

Currently, in Legacy the timestamp stored in the database is always midnight in the server's timezone, while in Platform it is always in UTC. This PR changes how values of Date Field Type are handled to make the behavior consistent with Platform. It also makes sure that the displayed values are also in UTC and unaffected by server's timezone.

TODO:

  • Migration script that changes values saved in the database to UTC.

@andrerom
Copy link
Contributor

Another todo here:

  • Check if only eZ Date datatype uses this lib class, as the fix seems to be in the wrong place on first view but if only used for Date datatype it can be ok perhaps.

@mateuszbieniek mateuszbieniek self-assigned this Sep 6, 2018
@mateuszbieniek
Copy link
Contributor

@andrerom I agree - eZDate is used in other places, so I prepared new PR with a different approach:
#1401

@andrerom
Copy link
Contributor

Closing in favour of #1401 as this PR is too intrusive on lib classes used several places in the system.

@andrerom andrerom closed this Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants