Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZEE-3159: Added support for items in the trash for SubtreeLimitationType #3040

Merged
merged 9 commits into from
Jun 19, 2020
Merged

EZEE-3159: Added support for items in the trash for SubtreeLimitationType #3040

merged 9 commits into from
Jun 19, 2020

Conversation

mateuszdebinski
Copy link
Contributor

@mateuszdebinski mateuszdebinski commented Jun 3, 2020 •
edited
Loading

Question Answer
JIRA issue EZEE-3159
Bug yes
New feature no
Target version 7.5
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@mateuszdebinski mateuszdebinski changed the title [WIP]EZEE-3159 added support for items in the trash for SubtreeLimitationType and LocationLimitationType [WIP]EZEE-3159: Added support for items in the trash for SubtreeLimitationType Jun 4, 2020
@mateuszdebinski mateuszdebinski changed the title [WIP]EZEE-3159: Added support for items in the trash for SubtreeLimitationType EZEE-3159: Added support for items in the trash for SubtreeLimitationType Jun 8, 2020
ViniTou
ViniTou reviewed Jun 10, 2020
View reviewed changes
Copy link
Contributor

@ViniTou ViniTou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we still waiting for unit/integration tests?

eZ/Publish/Core/Persistence/Legacy/Content/Location/Gateway.php Outdated Show resolved Hide resolved
@mateuszdebinski mateuszdebinski requested a review from ViniTou June 12, 2020 12:40
michal-myszka
michal-myszka approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@michal-myszka michal-myszka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@lserwatka lserwatka merged commit 706a7c1 into 7.5 Jun 19, 2020
@lserwatka lserwatka deleted the EZEE-3159 branch June 19, 2020 13:12
@lserwatka
Copy link
Member

@mateuszbieniek you can merge it up to ezplatform-kernel/1.0 and master.

@mateuszbieniek
Copy link
Contributor

@lserwatka I think you pinged wrong Mateusz ;) @mateuszdebinski

@mateuszdebinski
Copy link
Contributor Author

@lserwatka I did it in the morning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@konradoboza konradoboza konradoboza approved these changes

@michal-myszka michal-myszka michal-myszka approved these changes

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

@mateuszbieniek mateuszbieniek Awaiting requested review from mateuszbieniek

@ViniTou ViniTou Awaiting requested review from ViniTou

Assignees
No one assigned
Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mateuszdebinski @lserwatka @mateuszbieniek @adamwojs @mikadamczyk @ViniTou @konradoboza @michal-myszka @katarzynazawada