Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Added SortClause in testFieldIsEmptyInLocation #3031

Merged
merged 1 commit into from
May 12, 2020
Merged

[Tests] Added SortClause in testFieldIsEmptyInLocation #3031

merged 1 commit into from
May 12, 2020

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented May 9, 2020 •
edited by adamwojs
Loading

Question Answer
Type improvement
Target version 7.5 and up (incl. ezplatform-kernel)
BC breaks no

Looks like SearchServiceLocationTest::testFieldIsEmptyInLocation fails sometimes due to lack of deterministic ordering. Hopefully this test case won't be affected by EZP-31325.

TODO:

  • Improve testFieldIsEmptyInLocation
  • Wait for Travis
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@alongosz
[Tests] Added SortClause in testFieldIsEmptyInLocation
1c8e9d1 
SortClause was added to ensure search hits are returned in a deterministic manner
@alongosz alongosz requested review from mateuszbieniek, adamwojs and a team May 11, 2020 07:58
@alongosz alongosz merged commit 80e801d into 7.5 May 12, 2020
@alongosz alongosz deleted the fix-test-field-is-empty-in-location branch May 12, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@mateuszbieniek mateuszbieniek Awaiting requested review from mateuszbieniek

Assignees
No one assigned
Labels
Improvement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alongosz @adamwojs