EZP-31480: Introduced strict types for PermissionResolver & PermissionCriterionResolver #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nCriterionResolver
adamwojs
requested review from
alongosz,
michal-myszka,
mikadamczyk,
Nattfarinn,
ViniTou and
webhdx
mikadamczyk
approved these changes
Mar 16, 2020
alongosz
approved these changes
Mar 16, 2020
| @@ -25,5 +27,5 @@ interface PermissionCriterionResolver | |||
| * | |||
| * @return bool|\eZ\Publish\API\Repository\Values\Content\Query\Criterion | |||
| */ | |||
| public function getPermissionsCriterion($module, $function, ?array $targets = null); | |||
| public function getPermissionsCriterion(string $module = 'content', string $function = 'read', ?array $targets = null); | |||
There was a problem hiding this comment.
Can we use this opportunity to drop default arguments here?
Reasoning: I honestly would have never guessed that
$permissionCriterionResolver->getPermissionsCriterion();would give me Criteria for content/read - this is one of many policies.
There was a problem hiding this comment.
Definitely! @mikadamczyk requested this as well on Slack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterThis PR introduces strict types for the
\eZ\Publish\API\Repository\\eZ\Publish\API\Repository\PermissionResolverand\eZ\Publish\API\Repository\PermissionCriterionResolverTODO:
$ composer fix-cs).