Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31478: Dropped LSE FullText index from clean data #2984

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Mar 12, 2020

Question Answer
JIRA issue EZP-31478
Bug/Improvement yes
New feature no
Target version master (8.0@dev) for eZ Platform v3.0
BC breaks no
Tests pass yes
Doc needed no

Since eZ Platform v1.9 the ezplatform:reindex Symfony command re-indexes all Content items after installation (ezplatform:install). Having Legacy Search Engine FullText index data in initial data (a.k.a cleandata.sql) is both redundant and obsolete, since it might be outdated anyway.

Moreover since eZ Platform v2.5.6, the ezplatform:install command accepts --skip-indexing option, so this even could be seen as a bug. The bug is not visible by accident due to changes from #2940 released in eZ Platform v2.5.9, so there's no point in fixing it for 7.5 branch.

QA

Make sure the search engine set is legacy. Does not affect Solr.

  • Sanity for ezplatform:install without --skip-indexing option.
  • Sanity for ezplatform:install with --skip-indexing option. AdminUI search should not return any results until ezplatform:reindex is called. Optionally, If you want to observe the change in behavior, you could switch to the v3.0.0-beta5 tag or anything older.

TODO:

@alongosz alongosz force-pushed the ezp-31478-drop-lse-fulltext-index-from-cleandata branch from f8f8c2c to 90f049c Compare March 13, 2020 09:27
@alongosz alongosz merged commit 223967a into ezsystems:master Mar 16, 2020
@alongosz alongosz deleted the ezp-31478-drop-lse-fulltext-index-from-cleandata branch March 16, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants