EZP-31477: Fixed loading Site Accesses on limitation list #2983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikadamczyk
requested review from
Nattfarinn,
adamwojs,
alongosz,
ViniTou,
webhdx and
michal-myszka
2 tasks
ViniTou
approved these changes
Mar 13, 2020
alongosz
requested changes
Mar 13, 2020
adamwojs
approved these changes
Mar 13, 2020
|
@alongosz fixed, thanks for the vigilance! |
alongosz
approved these changes
Mar 13, 2020
micszo
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterList of SiteAccesses on limitation list should be fetched from the service, not from configuration. We have an extension point which allows extending the list of SiteAccesses. To fetch all of SiteAccesses the siteAccessService should be used.
QA:
you need to check whether the limitations based on SiteAccesses continue to work
TODO:
$ composer fix-cs).