EZP-31113: Implemented indexing subtree after assigning Section to it #2862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmadejski
changed the title
lserwatka
approved these changes
Nov 7, 2019
adamwojs
approved these changes
Nov 7, 2019
|
@kmadejski please remember to replace signal/slots with events on |
|
@adamwojs yep, there is even a note in PR, but I'll add it to ToDo list. |
alongosz
requested changes
Nov 7, 2019
kmadejski
changed the title
kmadejski
changed the title
ViniTou
approved these changes
Nov 7, 2019
alongosz
approved these changes
Nov 7, 2019
andrerom
approved these changes
Nov 7, 2019
alongosz
changed the title
micszo
reviewed
Nov 22, 2019
|
@micszo no, it's not a matter of configuration. It's due to the implementation of calling Solr. Here you can find a follow-up ticket for it: https://jira.ez.no/browse/EZP-30963. Unfortunately, I didn't have time to take care of it yet. |
micszo
approved these changes
Nov 25, 2019
4 tasks
|
Merged to 7.5 and removed when merged up to Also rebased SolrBundle PR and restarted tests on http cache PR, once they are green now they should be ready, but will be handled by @adamwojs as he will look into a few things including event handling for master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.5/masterAssignSectionToSubtreeSignalis not handled properly in both search implementations as well as in HTTP cache.Note: These changes will be removed on merge-up and the second PR targeting master will be created.
TODO:
$ composer fix-cs).master).