Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31098: Introduced strict types for URLWildcardService #2855

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Nov 1, 2019

Question Answer
JIRA issue EZP-31098
Bug/Improvement yes
New feature no
Target version master
BC breaks yes
Tests pass yes
Doc needed yes

This PR introduces strict types for the \eZ\Publish\API\Repository\URLWildcardService

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs adamwojs force-pushed the url_wildcard_service_typehint branch from 76d00d7 to 109363d Compare November 7, 2019 12:05
@adamwojs
Copy link
Member Author

adamwojs commented Nov 7, 2019

PR rebased in order to fix code style issues

@adamwojs adamwojs force-pushed the url_wildcard_service_typehint branch from 109363d to f08ef42 Compare November 7, 2019 14:56
@adamwojs adamwojs merged commit 08b7b1a into master Nov 7, 2019
@adamwojs adamwojs deleted the url_wildcard_service_typehint branch November 7, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants