Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-30985: Replaced usage of deprecated transchoice Twig function #2831

Merged
merged 1 commit into from
Oct 18, 2019
Merged

EZP-30985: Replaced usage of deprecated transchoice Twig function #2831

merged 1 commit into from
Oct 18, 2019

Conversation

emodric
Copy link
Contributor

@emodric emodric commented Oct 16, 2019 •
edited
Loading

Question Answer
JIRA issue EZP-30985
Bug/Improvement yes
New feature no
Target version master
BC breaks yes? (New translation strings required)
Tests pass no
Doc needed no

transchoice has been deprecated since Symfony 4.2.

Here, I've opted for using separate translation strings, rather than reimplementing trans with ICU MessageFormat which requires renaming translation files to have a new prefix for ICU messages to be recognized.

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@emodric emodric changed the title Replace usage of deprecated transchoice Twig function EZP-30985: Replaced usage of deprecated transchoice Twig function Oct 16, 2019
@alongosz alongosz merged commit 11d3cdd into ezsystems:master Oct 18, 2019
@michalmilc90 michalmilc90 mentioned this pull request Nov 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@alongosz alongosz alongosz approved these changes

Assignees
No one assigned
Labels
Improvement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emodric @adamwojs @alongosz