Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-30968: Added method to count the number of content's reverse relations #2774

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Sep 25, 2019

Question Answer
JIRA issue EZP-30968
Bug/Improvement yes
New feature no
Target version 7.5
BC breaks no
Tests pass yes/no
Doc needed yes/no

This method is needed to add pagination to content's reverse relation list

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@mikadamczyk mikadamczyk changed the title EZP-30900: Added method to count the number of content's reverse relations EZP-30968: Added method to count the number of content's reverse relations Sep 25, 2019
@mikadamczyk mikadamczyk self-assigned this Sep 25, 2019
eZ/Publish/API/Repository/Tests/ContentServiceTest.php Outdated Show resolved Hide resolved
eZ/Publish/API/Repository/Tests/ContentServiceTest.php Outdated Show resolved Hide resolved
eZ/Publish/API/Repository/Tests/ContentServiceTest.php Outdated Show resolved Hide resolved
/**
* {@inheritdoc}
*/
public function countReverseRelations(ContentInfo $contentInfo): int
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember to drop it on merge up.

eZ/Publish/Core/Repository/ContentService.php Show resolved Hide resolved
/**
* {@inheritdoc}
*/
public function countReverseRelations(ContentInfo $contentInfo): int
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember to drop it on merge up.

@mikadamczyk mikadamczyk force-pushed the EZP-30968-count-reverse-relations branch from c552178 to 2654fb6 Compare September 26, 2019 06:51
@mikadamczyk mikadamczyk force-pushed the EZP-30968-count-reverse-relations branch from 2654fb6 to c545389 Compare September 26, 2019 07:48
@adamwojs
Copy link
Member

@mikadamczyk Rebase is needed here.

@lserwatka
Copy link
Member

You can merge it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants