-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-30968: Added method to count the number of content's reverse relations #2774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
requested changes
Sep 25, 2019
eZ/Publish/Core/Persistence/Legacy/Content/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/Persistence/Legacy/Content/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function countReverseRelations(ContentInfo $contentInfo): int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remember to drop it on merge up.
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function countReverseRelations(ContentInfo $contentInfo): int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remember to drop it on merge up.
c552178
to
2654fb6
Compare
adamwojs
reviewed
Sep 26, 2019
alongosz
approved these changes
Sep 26, 2019
2654fb6
to
c545389
Compare
ViniTou
approved these changes
Sep 27, 2019
@mikadamczyk Rebase is needed here. |
c545389
to
baf0a10
Compare
Merged
2 tasks
pawbuj
approved these changes
Oct 1, 2019
baf0a10
to
133fc32
Compare
4 tasks
katarzynazawada
approved these changes
Oct 1, 2019
You can merge it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.5
This method is needed to add pagination to content's reverse relation list
TODO:
$ composer fix-cs
).