Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-30828: Replaced \Symfony\Component\EventDispatcher\Event usage in favor of Symfony\Contracts\EventDispatcher\Event #2730

Merged
merged 1 commit into from
Aug 9, 2019
Merged

EZP-30828: Replaced \Symfony\Component\EventDispatcher\Event usage in favor of Symfony\Contracts\EventDispatcher\Event #2730

merged 1 commit into from
Aug 9, 2019

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Aug 8, 2019

Question Answer
JIRA issue EZP-30828
Bug/Improvement yes
New feature no
Target version master
BC breaks yes
Tests pass ?
Doc needed no

Replaced \Symfony\Component\EventDispatcher\Event usage in favor of Symfony\Contracts\EventDispatcher\Event.

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs
EZP-30828: Replaced \Symfony\Component\EventDispatcher\Event usage in…
9260feb 
… favor of Symfony\Contracts\EventDispatcher\Event
@adamwojs adamwojs self-assigned this Aug 8, 2019
@lserwatka lserwatka merged commit a1e304d into master Aug 9, 2019
@lserwatka lserwatka deleted the ezp_30828 branch August 9, 2019 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@micszo micszo micszo approved these changes

Assignees

@adamwojs adamwojs

Labels
Improvement QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamwojs @mikadamczyk @micszo @lserwatka