Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-30819: Removed deprecated controller references from routes definitions #2725

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Aug 5, 2019

Question Answer
JIRA issue EZP-30819
Bug/Improvement yes
New feature no
Target version master
BC breaks no
Tests pass yes
Doc needed no

Referencing controllers with <Bundle>:<Controller>:<Action> syntax (aka bundle notation) is deprecated since Symfony 4.1 and generate the following log entries:

[2019-08-05 19:39:35] php.INFO: User Deprecated: Referencing controllers with FrameworkBundle:Redirect:redirect is deprecated since Symfony 4.1, use "Symfony\Bundle\FrameworkBundle\Controller\RedirectController::redirectAction" instead. {"exception":"[object] (ErrorException(code: 0): User Deprecated: Referencing controllers with FrameworkBundle:Redirect:redirect is deprecated since Symfony 4.1, use \"Symfony\\Bundle\\FrameworkBundle\\Controller\\RedirectController::redirectAction\" instead. at /home/awojs/eZ/ezplatform-ee-3.0/vendor/symfony/framework-bundle/Routing/DelegatingLoader.php:95)"} []

More informations: https://symfony.com/blog/new-in-symfony-4-1-deprecated-the-bundle-notation

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs adamwojs self-assigned this Aug 5, 2019
@lserwatka lserwatka merged commit 3ba77f5 into master Aug 8, 2019
@lserwatka lserwatka deleted the ezp_30819 branch August 8, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants