Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Twig deprecations #2708

Merged
merged 3 commits into from
Aug 6, 2019
Merged

Remove Twig deprecations #2708

merged 3 commits into from
Aug 6, 2019

Conversation

emodric
Copy link
Contributor

@emodric emodric commented Jul 23, 2019 •
edited by adamwojs
Loading

Question Answer
JIRA issue https://jira.ez.no/browse/EZP-30814
Bug/Improvement yes
New feature no
Target version 7.5
BC breaks no
Tests pass yes
Doc needed no

  • spaceless tag was deprecated in favor of spaceless filter recently. This uses the apply tag added in Twig 2.9 to apply the filter to chunks of markup instead of using the tag.

  • for ... if is deprecated since Twig 2.10

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@emodric emodric changed the title Use spaceless filter instead of spaceless tag Remove Twig deprecations Jul 23, 2019
andrerom
andrerom approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@andrerom andrerom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, would be good indeed to get rid of deprecation warnings on 2.5 to improve DX and simplify preparing for upgrade (by letting partners have relevant deprecation notices, not flood of deprecations by platform as well).

@lserwatka
Copy link
Member

@micszo we will need some QA here

This was referenced Aug 4, 2019
Merged
Merged
Merged
Merged
Merged
Closed
@micszo micszo self-assigned this Aug 5, 2019
@adamwojs adamwojs mentioned this pull request Aug 5, 2019
Merged
micszo
micszo approved these changes Aug 6, 2019
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with regression suite in PB PR with all the PRs.
Sanities OK.

@micszo micszo removed their assignment Aug 6, 2019
@lserwatka lserwatka merged commit 30d08b8 into ezsystems:7.5 Aug 6, 2019
@lserwatka
Copy link
Member

@alongosz could you merge it up?

@alongosz
Copy link
Member

alongosz commented Aug 6, 2019

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@andrerom andrerom andrerom approved these changes

@micszo micszo micszo approved these changes

Assignees
No one assigned
Labels
QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@emodric @lserwatka @alongosz @adamwojs @andrerom @micszo