EZP-30749: Passed explicitly event name to dispatcher #2700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawbuj
approved these changes
Jul 12, 2019
alongosz
approved these changes
Jul 12, 2019
| use eZ\Publish\API\Repository\Events\Content\PublishVersionEvent as PublishVersionEventInterface; | ||
| use eZ\Publish\API\Repository\Events\Content\RevealContentEvent as RevealContentEventInterface; | ||
| use eZ\Publish\API\Repository\Events\Content\UpdateContentEvent as UpdateContentEventInterface; | ||
| use eZ\Publish\API\Repository\Events\Content\UpdateContentMetadataEvent as UpdateContentMetadataEventInterface; |
There was a problem hiding this comment.
This long import list makes me feel that maybe use eZ\Publish\API\Repository\Events\Content; and e.g.
$this->eventDispatcher->dispatch(
new UpdateContentMetadataEvent($content, ...$eventData),
Content\UpdateContentMetadataEvent::class
);would be better.
|
Merging. To be tested with #2682. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterEvent names should be passed explicitly to the dispatcher, otherwise subscribers will be forced to use
eZ\Publish\Core\Event\instead ofeZ\Publish\API\Repository\Events\TODO:
$ composer fix-cs).