Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-30457: FieldType::getSortInfo should be implemented by impl. only if the FT is sortable #2677

Merged
merged 2 commits into from
Jun 27, 2019
Merged

EZP-30457: FieldType::getSortInfo should be implemented by impl. only if the FT is sortable #2677

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7cdc9b
EZP-30457: Method eZ\Publish\Core\FieldType\FieldType::getSortInfo sh…
adamwojs Jun 26, 2019
fa8fc75
fixup! EZP-30457: Method eZ\Publish\Core\FieldType\FieldType::getSort…
adamwojs Jun 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eZ/Publish/Core/FieldType/FieldType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ public function applyDefaultSettings(&$fieldSettings)
*/
protected function getSortInfo(Value $value)
{
throw new \RuntimeException('Not implemented, yet.');
return false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo null would be better

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo null would be better

@pawbuj, I agree but this has deeper consequences. Right now false is internally treated as "no sort info".

@adamwojs Does this PR block anything?
Asking because I think we need to rectify this and indeed use null.
Use case: you have boolean FT which you want to sort by false first.

Copy link
Member Author

@adamwojs adamwojs Jun 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamwojs Does this PR block anything?

Generic Field Type depends on this change.

Asking because I think we need to rectify this and indeed use null.
Use case: you have boolean FT which you want to sort by false first.

null is also allowed value here, see \eZ\Publish\Core\FieldType\Null\Type::getSortInfo. Using false is just a "non-formal" convention for non-sortable FT.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null is also allowed value here, see \eZ\Publish\Core\FieldType\Null\Type::getSortInfo. Using false is just a "non-formal" convention for non-sortable FT.

What are the implications of returning null then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no implications at this point. Value returned by getSortInfo is passed as \eZ\Publish\SPI\Persistence\Content\FieldValue::$sortKey to \eZ\Publish\Core\Persistence\Legacy\Content\FieldValue\Converter implementation and needs to be handled there.

Suggestion applied in fa8fc75

}

/**
Expand Down