EZP-30462: Unified Field Type service tag names

[mikadamczyk]

Question	Answer
JIRA issue	EZP-30462
Improvement	yes
New feature	no
Target version	master
BC breaks	no
Tests pass	yes/no
Doc needed	yes

Tags used to register Field Type features in the dependency injection container should be consistent and follow Symfony convention (snake case)

ezpublish.fieldType => ezplatform.field_type
ezpublish.fieldType.indexable => ezplatform.field_type.indexable
ezpublish.storageEngine.legacy.converter => ezplatform.field_type.legacy_storage.converter
ezpublish.fieldType.parameterProvider => ezplatform.field_type.parameter_provider
ezpublish_rest.field_type_processor => ezplatform.field_type.rest.processor

Related PR:
ezsystems/repository-forms#292
ezsystems/ezplatform-matrix-fieldtype#15

QA: We have to make sure that all field types work correctly

TODO:

• Implement feature / fix a bug.
• Implement tests.
• Fix new code according to Coding Standards ($ composer fix-cs).
• Ask for Code Review.

[ViniTou]

This must be rebased
@mikadamczyk

[mikadamczyk]

@ViniTou @alongosz it is rebased and ready for review

[pawbuj]

For twig helpers we choosed ez prefix so I think that we should be consequent and use it also for tags, instead of ezplatform

[mikadamczyk]

@alongosz @ViniTou @webhdx @Nattfarinn what do you think?

[Nattfarinn]

Fair question. It does make sense to rename tags to ez, but on the other hand we'll loose the oportunity to distinguish products in future (to have separate ezplatform and ezplatform-ee tags) in case we want it next major (and as we're thinking about ezpaltform-admin-ui-ee maybe it does make sense as well).

I am 33.33% for ez. and 66.66% for ezplatform. (and 0.01% for capybara. because how awsome they are).

But, to beat next question, I wouldn't go that far to prefix non-FQCN services (and event names in case we keep ezplatform. prefix here) with just ez.. Services in my opinion have to remain product oriented.

[adamwojs]

+1 for the ezplatform prefix.

[alongosz]

Correct prefix is ezplatform because we won't use the same tag in a completely different product.
+1 for what @Nattfarinn have just requested.

[mikadamczyk]

@Nattfarinn fixed, also @alongosz @pawbuj

[micszo]

Testing discovered https://jira.ez.no/browse/EZEE-2801.
Update: ticket is closed, it was mistakenly identified to occur on EE master.
It is fixed in ezsystems/ezplatform-matrix-fieldtype#15.

[micszo]

Btw, stumbled upon the ez star rating issue: https://jira.ez.no/browse/EZP-30677.

[alongosz]

@micszo resolved conflict with base branch.

[micszo]

Tested together with:
ezsystems/repository-forms#292
ezsystems/ezplatform-matrix-fieldtype#15

[emodric]

Why wasn't ezpublish.fieldType.externalStorageHandler tag renamed?

[adamwojs]

Good catch @emodric, we forgot about this one 😅 I will rename it in follow-up PR.