EZP-30390: Removed deprecated ezprice field type #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
requested changes
Apr 9, 2019
There was a problem hiding this comment.
Great!
-
What we need to start doing is documenting what we dropped in
/doc/bc/changes-8.0.mdunder## Removed featuressection. -
We probably need some upgrade script which will delete
ezpricefrom Content item attributes and Content Types. It's quite possible someone still has this in his Legacy database and didn't even notice :)
|
Was it confirmed that ezCommerce is not using that one? :D |
Yes. Sorry, we shouldn't discuss this internally, but here, probably ;) |
|
PR updated according to @alongosz suggestions. |
alongosz
requested changes
Apr 11, 2019
eZ/Publish/Core/Search/Legacy/Tests/Content/AbstractTestCase.php
Outdated
Show resolved
Hide resolved
mikadamczyk
approved these changes
Apr 12, 2019
alongosz
approved these changes
Apr 12, 2019
|
PR has been rebased. |
alongosz
reviewed
May 8, 2019
4 tasks
adamwojs
added a commit
to adamwojs/ezpublish-kernel
that referenced
this pull request
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master(8.0)Removed
ezpricefield type.TODO:
$ composer fix-cs).