EZP-29504 : add siteaccess parameter to ezplatform:reindex

[jlchassaing]

Question	Answer
JIRA issue	EZP-29504
Bug	yes
New feature	no
Target version	6.x
BC breaks	no
Tests pass	yes
Doc needed	no

Add siteaccess parameter when ezplatform:reindex is run in multi-process on a multi-siteaccess multi-repository environment

TODO:

• Implement feature / fix a bug.
• Implement tests.
• Fix new code according to Coding Standards ($ composer fix-cs).
• Ask for Code Review.

[andrerom]

@emodric has reported a regression on this: https://jira.ez.no/browse/EZP-29640

I'm guessing he hits a case where $this->siteaccess is null, where Process ends up escaping it as empty string: https://github.com/symfony/process/blob/3.4/Process.php#L1719-L1721

@jlchassaing Are you up for improving this a bit to avoid passing this if not set?
@emodric would you be able to confirm that assumption?

[emodric]

@andrerom Yep, when adding an explicit siteaccess argument, then it works fine.

[andrerom]

@emodric Would something like this work for you:

diff --git a/eZ/Bundle/EzPublishCoreBundle/Command/ReindexCommand.php b/eZ/Bundle/EzPublishCoreBundle/Command/ReindexCommand.php
index 807cdf9725..e6104be304 100644
--- a/eZ/Bundle/EzPublishCoreBundle/Command/ReindexCommand.php
+++ b/eZ/Bundle/EzPublishCoreBundle/Command/ReindexCommand.php
@@ -375,12 +375,12 @@ EOT
      */
     private function getPhpProcess(array $contentIds, $commit)
     {
-        $process = new ProcessBuilder([
+        $process = new ProcessBuilder(array_filter([
             file_exists('bin/console') ? 'bin/console' : 'app/console',
             $this->siteaccess ? '--siteaccess=' . $this->siteaccess : null,
             'ezplatform:reindex',
             '--content-ids=' . implode(',', $contentIds),
-        ]);
+        ]));
         $process->setTimeout(null);
         $process->setPrefix($this->getPhpPath());
 

[emodric]

@andrerom It should work, yes.