EZP-20057: Merge Service tests into integration tests

[alongosz]

Status: Ready for a review
Fixes: EZP-20057

TODO:

• Remove obsolete Service integration tests (6ddfddc).
• Fix found bugs in related integration tests (af01f8b).
• Add missing TrashItem::$path property (1e5528b).
• Check integration tests coverage for ContentTest*.
• Check integration tests coverage for ContentTypeTest*.
• Check integration tests coverage for LanguageTest*.
• Check integration tests coverage for LocationTest*.
• Check integration tests coverage for NameSchemaTest*.
• Check integration tests coverage for ObjectStateTest*.
• Check integration tests coverage for RepositoryTest*.
• Check integration tests coverage for RoleTest*.
• Check integration tests coverage for SearchTest*.
• Check integration tests coverage for SectionTest*.
• Check integration tests coverage for TrashTest*.
• Check integration tests coverage for UserTest*.

* from the removed namespace \eZ\Publish\Core\Repository\Tests\Service\Integration.

[alongosz]

We need to be more careful when testing occurrences of exceptions :-)
For instance, if we test for InvalidArgumentException we should also use @expectedExceptionMessage to ensure checking for the proper exception.

An example: in af01f8b there are fixes for bugs related to this - test cases had mainLanguageCode and names struct fields missing, which also resulted in the InvalidArgumentException, but unrelated to what should actually be tested.

// cc @andrerom @pspanja @Nattfarinn

[alongosz]

I looked over all the tests in \eZ\Publish\Core\Repository\Tests\Service\Integration namespace, improved proper integration tests and added some unit tests :)

Review ping @andrerom @Nattfarinn @pspanja

[andrerom]

+1, congratulations on getting rid of 10k lines of code 🎉 👍

[yannickroger]

Impressive diff!

[andrerom]

yeah, this was a long overdue (issue was created 12/Nov/12 4:47 PM..) cleanup to move integration tests that was part of unit tests into the actual integration tests. Small step to make it easier to work on repository :)

There is one thing here which is not test, but was uncovered here and that is: 1e5528b aligning TrashItem with Location on this.

[andrerom]

As this thing is a needed cleanup, passing, not introducing new skips, and difficult to review I'm merging it. Thanks @alongosz

Merging using merge commit for keeping history given this tackles several things.