Refactor FieldValueConverterRegistryPass not to use static callbacks #1863
Conversation
| * | ||
| * @return Author | ||
| */ | ||
| public static function create() |
There was a problem hiding this comment.
you should deprecate and not remove directly
|
Restored |
| @@ -22,11 +22,13 @@ class FloatConverter implements Converter | |||
| const HAS_MAX_VALUE = 2; | |||
|
|
|||
| /** | |||
| * @deprecated since 6.8, will be removed in 7.x, use default constructor instead. | |||
There was a problem hiding this comment.
nitpic, but @deprecated is no the title of the doc block :)
so place it after "NOTE:" part.
There was a problem hiding this comment.
Ok, fixed in eb1b693 :)
| @@ -5,6 +5,8 @@ | |||
| * | |||
| * @copyright Copyright (C) eZ Systems AS. All rights reserved. | |||
| * @license For full copyright and license information view LICENSE file distributed with this source code. | |||
| * | |||
| * @version | |||
| * @return float | ||
| * @deprecated since 6.8, will be removed in 7.x, use default constructor instead. | ||
| * | ||
| * @return Float |
|
Added missing CS fixes in affa731 (sorry!). |
|
From comment at #1812, should this be closed now? |
Can, but this is a nice cleanup and already done, so would like to merge it for 6.8 if you approve it :) |
| * @return Float | ||
| * @deprecated since 6.8, will be removed in 7.x, use default constructor instead. | ||
| * | ||
| * @return float |
There was a problem hiding this comment.
Nitpick: FloatConverter :)
| * @return Integer | ||
| * @deprecated since 6.8, will be removed in 7.x, use default constructor instead. | ||
| * | ||
| * @return int |
|
Looks like almost every converter has wrong doc on |
alongosz
force-pushed
the
refactor-field-value-converters-pass
branch
from
17eaa0f to
8479987
Compare
|
It's ready now. // cc @andrerom |
|
Thanks @alongosz |
This PR refactors
eZ\Publish\Core\Base\Container\Compiler\Storage\Legacy\FieldValueConverterRegistryPassnot to use static callback when registering concreteFieldValueConverters.This change simplifies injecting any dependency into any
FieldValueConverter(and makes the code cleaner).On the other hand, to compensate for "losing" laziness on Converters, Registry is now lazy.
TODO:
FieldValueConverterRegistryPass.createin concreteFieldValueConverterimplementations.ezpublish.persistence.legacy.field_value_converter.registrylazylazyandcallbackattributes fromezpublish.storageEngine.legacy.convertertagged-services.