[Behat] Add BasicContent, ContentType, Field, Role and User Contexts #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelcleverti
force-pushed
the
BehatContexts
branch
3 times, most recently
from
f6a53d6 to
f55c33b
Compare
6 tasks
| @@ -0,0 +1,209 @@ | |||
| <?php | |||
| /** | |||
| * This file is part of the BehatBundle package. | |||
miguelcleverti
force-pushed
the
BehatContexts
branch
2 times, most recently
from
17cca31 to
0835212
Compare
| * @param array $fields | ||
| * @param mixed $contentType The content type identifier | ||
| * | ||
| * @return mixed|string |
There was a problem hiding this comment.
What is the returned value exactly ?
miguelcleverti
force-pushed
the
BehatContexts
branch
from
0835212 to
eb15b94
Compare
|
@bdunogier I made some changes like you suggested. |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to deprecate
BehatBundlerepository some Contexts will be moved into the kernel.Making the Contexts
classesand nottraits(as some of them still are in BehatBundle) should improve the overall flexibility and maintainability of the code.One if the main objectives is to use this Contexts with other Bundles BDD, such as PlatformUI, running each behat suite with the various needed Contexts instead of one with everything.
PS: this PR contains a lot of code but it has already been reviewed before, the code was just moved basically.