Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Travis] Added logging into Docker Hub #661

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented Jun 22, 2021

Follow up to #644, which was done only for v2.5 or higher (but never for 1.13).

This change is needed in two places, as for external repos bin/.travis/trusty/setup_from_external_repo.sh is called, but for metarepo Docker is invoked directly.

Example failures:
https://travis-ci.com/github/ezsystems/ezplatform/jobs/517257672
https://travis-ci.com/github/ezsystems/ezpublish-kernel/jobs/517204307

@mnocon mnocon force-pushed the travis-login-to-docker-hub branch from c854896 to 0e2be5d Compare June 22, 2021 08:21
@mnocon mnocon marked this pull request as ready for review June 22, 2021 12:33
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@micszo micszo merged commit 02d1633 into 1.13 Jun 24, 2021
@micszo micszo deleted the travis-login-to-docker-hub branch June 24, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants