Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Travis] Disabled symlinking of local dependency #650

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented Feb 25, 2021

Example failure:
https://travis-ci.com/github/ezsystems/ezplatform-http-cache/jobs/486034188

Error:

 ---> ec18ce700090

Step 6/10 : COPY vendor/ezsystems/ezplatform-http-cache/docs/varnish/vcl/varnish5.vcl /etc/varnish/default.vcl

Service 'varnish' failed to build: COPY failed: stat /var/lib/docker/tmp/docker-builder696197820/var/www/ezplatform-http-cache/docs/varnish/vcl/varnish5.vcl: no such file or directory

Varnish container fails to builds, because it's not able to find the vendor/ezsystems/ezplatform-http-cache/docs/varnish/vcl/varnish5.vcl file.

This happens only for builds in ezplatform-http-cache repository and is caused by #648 .

In #648 I've changed the repository type to path. This has one unforseen consequence - packages downloaded using that method are symlinked by default (Ref: https://getcomposer.org/doc/05-repositories.md#path)

The PR dependency is moved on the host to /home/travis/build/ezplatform/ezplatform-http-cache and there is no ezsystems/ezplatform-http-cache in the vendor directory - there is only a symlink to the actual location.
Looks like Docker is unable to resolve (follow) the symlink when trying to copy the file and reports that the file does not exists.

This solution disables symliniking of the dependency -it's mirrored (copied) instead, so that the files are where they are supposed to be and everything works as before.

I've tested the solution on 3.2 with 2 PRs:
#649
ezsystems/ezplatform-http-cache#145
And Varnish container is setup correctly.

@micszo micszo merged commit 95c5d8f into 2.5 Feb 26, 2021
@micszo micszo deleted the fix-http-cache-tests branch February 26, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants