-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update to use Docker 17.04 for improved performance #173
Conversation
1c96a23
to
10a0ca4
Compare
…r speed on Mac Also added inline todo's for some changes needed to be able to also use with Docker Swarm. Further reading: - ":cached": https://gist.github.com/yallop/d4af9dd1bb33ae61d48adf86692cdf9e - 3.2 yml example: https://github.com/docker/example-voting-app/blob/master/docker-compose.yml
any progress with this feature to add this to platform? |
@timiTao None, it was a prototype and would need cleanup on which folders use which mount options, and might need Docker for Mac to also gain support for Also the need to run backend in prod disappears with v2 so cleanup should remove that as it's more of a hack. But the bump to docker compose 3.x format can be extracted and done on master right now if we want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have copied these edits into a private local repo and am running docker-compose successfully and without incident on my machine, as laid out in the README.md file, for a project I'm working on. Very nice! Thank you for these improvements @andrerom :) It has greatly sped up my development cycle.
EDIT: I happen to be on v1.10.0-rc3, as that's what was the latest when I started my current task. Forgot to mention the version earlier. :)
@andrerom I run this on my local machine with ezPlatform + ee and working fine. I convince one person in Polish office to do that too on mac. Others consider this, with solution like that. But we of them manually edit file That is why I asked when will be this officialy 👍 Moving to new format always be some progress. Funny things is that, it was one of first things in office to improve. After I did my job mostly, somebody told me from other office, that you did this PR - nobody used Docker For Mac in my office. |
Closing in favor of #192 NOTE: Concept for setting backend in PROD mode for v1 performance is not part of that, but can be opened separately for anyone that wants to try. Instead of the rewrite rules approach attempted here it should perhaps be:
This way also php built in server ( |
Consists of three changes:
:cached
(PR) volume mount point feature to improve performance/ez|/api
)Those two changes improves the performance to a level where working with containers is ok'ish, even on a older 2011 Macbook Pro.
Note: With changes we do in v2 and further improvements on docker itself last change for nginx conf might not be needed anymore (for people wanting to develop on backend they would anyway want it to also run in DEV)
Todo:
Possible Followups:
docker-compose.yml
file at root for simplified use (no need to always joggle which files to use)How to run this:
Before you try, make sure you to install Docker 17.04 or higher (only available in Docker for Mac edge channel atm)!
For full instructions see the
doc/docker-compose/Readme.md
, short version for dev setup: