-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EZP-26748: Wrong image URI when content name has extended UTF characters #150
Conversation
Review ping @andrerom @bdunogier - this is a (perhaps too) simple solution. I have hardcoded it because AFAIK ezp is utf-8 only. |
I'm not a charset expert, but based on what I know it looks okay. Do we need to add the same thing to our tests bootstrap files, to be consistent ? |
@bdunogier Sounds good. Could you give some pointers? (Travis/Behat config?) |
For phpunit, it would probably be in |
Ok, that would be bootstrap.php in kernel, repoforms, pui and other repos, then? |
Bootstrap is one thing, we also more importantly need to add this in |
6ba5fe1
to
f9e0a58
Compare
Update: Added same in |
Don't forget to send it to QA 😄 |
Sent to QA. |
Merged in 1.7: 45aa9a6 |
Fixes the problem by ensuring UTF-8 is used, though this probably isn't the ideal way to do it. Anyway, let's see how the full tests go.