PostgreSQL do not support alias in update queries #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
approved these changes
Sep 26, 2018
There was a problem hiding this comment.
+1
But @alongosz might have some input* on how we can slightly re-organize the code here in order to be able to have some testing coverage for postgres and mysql.
However that is probably better as a followup on this one.
EDIT: * this has been reported as suggestion in #79
alongosz
approved these changes
Sep 26, 2018
There was a problem hiding this comment.
Looks good.
Indeed I have suggestion, see #79. Of course this is side topic not blocking this PR :)
I have some experience with the stuff I described there, so I'll try to start on that in the evening (mainly to see if this is gonna be as quick as I expect 😀 )
vidarl
added a commit
that referenced
this pull request
Oct 9, 2018
vidarl
added a commit
that referenced
this pull request
Oct 9, 2018
vidarl
added a commit
that referenced
this pull request
Oct 18, 2018
vidarl
added a commit
that referenced
this pull request
Oct 26, 2018
vidarl
added a commit
that referenced
this pull request
Oct 26, 2018
vidarl
added a commit
that referenced
this pull request
Oct 26, 2018
* Moved commands' db query functions to dedicated Gateway service * Fixed regression in 'PostgreSQL do not support alias in update queries (#78)' commit * Added tests for DB gateway service * Added Gateway tests on Travis * Added kernel 1.13 tests on Travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to https://github.com/ezsystems/ezplatform-xmltext-fieldtype/issues/77