EZP-27327: Fix User / ContentType / Section facet support in Solr #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
force-pushed
the
facets-EZP-26465-alt
branch
from
5a6d608 to
3203af2
Compare
andrerom
changed the title
andrerom
force-pushed
the
facets-EZP-26465-alt
branch
from
3203af2 to
6691f84
Compare
1 task
alongosz
approved these changes
May 10, 2017
| @@ -39,7 +39,7 @@ public function __construct(FacetBuilderVisitor $facetBuilderVisitor) | |||
| * | |||
| * @return \eZ\Publish\API\Repository\Values\Content\Search\SearchResult | |||
| */ | |||
| public function extract($data) | |||
| public function extract($data, array $facetBuilders = []) | |||
There was a problem hiding this comment.
Nitpick: missing PHPDoc for the new $facetBuilders param.
There was a problem hiding this comment.
fixed in 799c7a2
1. To be able to inject name 2. To be able to inject the builder itself eventualy See planned api improvments on facets: ezsystems/ezpublish-kernel#1960
andrerom
force-pushed
the
facets-EZP-26465-alt
branch
from
6691f84 to
1bf0c11
Compare
Nattfarinn
approved these changes
May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done:
namefrom the user provided value in FacetBuilder.modifier,ownerandgroup* The benefit of this approach over the one in #91 is that it reduces complexity of facet builder visitors by getting them to set id on the facet, which in turn better gurantees we use right facet builder with a given facet during extraction phase, this was proposed by @kore in 274875f#commitcomment-22050214