Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31423: Refactored SetupFactory to rely on Doctrine Connection #178

Merged
merged 3 commits into from
Mar 31, 2020
Merged

EZP-31423: Refactored SetupFactory to rely on Doctrine Connection #178

merged 3 commits into from
Mar 31, 2020

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Mar 25, 2020 •
edited
Loading

Question Answer
JIRA issue EZP-31423 blocking EZP-30921
Type improvement
Target eZ Platform version v3.0
BC breaks no
Tests pass yes
Doc needed no

This PR refactors test SetupFactory to stop relying on Database Handler from Zeta Components in favor of Doctrine Connection.
I've optimized loading a list of Content items to be indexed.
I've also refactored getTestConfigurationFile method simply because I couldn't look at it.

Checklist:

  • PR description is updated.
  • Tests are refactored.
  • new code follows Coding Standards.
  • Travis passes.
  • PR is ready for a review.

adamwojs
adamwojs approved these changes Mar 30, 2020
View reviewed changes
tests/lib/SetupFactory/LegacySetupFactory.php Outdated Show resolved Hide resolved
@alongosz alongosz force-pushed the ezp-31423-replace-dbh-with-doctrine-in-setup-factory branch from 58aff45 to ecf59bb Compare March 30, 2020 14:08
@alongosz alongosz merged commit f573342 into ezsystems:master Mar 31, 2020
@alongosz alongosz deleted the ezp-31423-replace-dbh-with-doctrine-in-setup-factory branch March 31, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nattfarinn Nattfarinn Nattfarinn left review comments

@adamwojs adamwojs adamwojs approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@webhdx webhdx webhdx approved these changes

@michal-myszka michal-myszka Awaiting requested review from michal-myszka

@ViniTou ViniTou Awaiting requested review from ViniTou

Assignees
No one assigned
Labels
Improvement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alongosz @adamwojs @mikadamczyk @Nattfarinn @webhdx