Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31021: Revised exception and command messages #162

Merged
merged 2 commits into from
Dec 2, 2019
Merged

EZP-31021: Revised exception and command messages #162

merged 2 commits into from
Dec 2, 2019

Conversation

DominikaK
Copy link
Contributor

@DominikaK DominikaK requested review from adamwojs and a team November 18, 2019 14:00
@DominikaK DominikaK mentioned this pull request Nov 18, 2019
Merged
2 tasks
michalmilc90
michalmilc90 approved these changes Nov 19, 2019
View reviewed changes
bundle/Command/SolrCreateIndexCommand.php Outdated Show resolved Hide resolved
adamwojs
adamwojs requested changes Nov 19, 2019
View reviewed changes
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DominikaK Unit tests need to be updated here.

@alongosz alongosz changed the title EZP-31021: Revise exception & command microcopy [REBASE REQUIRED] EZP-31021: Revise exception & command microcopy Nov 21, 2019
@DominikaK
Copy link
Contributor Author

Passing build with linked ezpublish-kernel changes (ezsystems/ezpublish-kernel#2878): https://travis-ci.org/ezsystems/ezplatform-solr-search-engine/builds/615020744

@DominikaK DominikaK force-pushed the ezp-31021-messages-revision branch from d805185 to 5c682e5 Compare November 29, 2019 13:31
@DominikaK DominikaK changed the title [REBASE REQUIRED] EZP-31021: Revise exception & command microcopy EZP-31021: Revised exception and command messages Nov 29, 2019
@alongosz alongosz merged commit 018a27c into ezsystems:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalmilc90 michalmilc90 michalmilc90 approved these changes

@MagdalenaZuba MagdalenaZuba MagdalenaZuba approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees
No one assigned
Labels
Improvement Ready for MERGE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DominikaK @adamwojs @MagdalenaZuba @michalmilc90 @alongosz