EZP-31118: Introduced strict types for ContenteService #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
force-pushed
the
content_service_typehint
branch
from
a93af45 to
2f7afd2
Compare
adamwojs
requested review from
alongosz,
michal-myszka,
mikadamczyk,
Nattfarinn,
ViniTou and
webhdx
ViniTou
approved these changes
Mar 12, 2020
alongosz
approved these changes
Mar 12, 2020
| @@ -127,7 +127,7 @@ public function renderContentEmbed($contentId, $viewType, array $parameters, $is | |||
| /** @var \eZ\Publish\API\Repository\Values\Content\Content $content */ | |||
| $content = $this->repository->sudo( | |||
| function (Repository $repository) use ($contentId) { | |||
| return $repository->getContentService()->loadContent($contentId); | |||
| return $repository->getContentService()->loadContent((int)$contentId); | |||
There was a problem hiding this comment.
TBH you should fix it here and enforce strict types in renderContentEmbed.
But can be done as a follow-up when handling renderContentEmbed by introducing strict types there and removing type cast here.
adamwojs
force-pushed
the
content_service_typehint
branch
from
2f7afd2 to
b4b1136
Compare
katarzynazawada
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterFixed issues reported in ezsystems/ezpublish-kernel#2866 (review):
TODO:
$ composer fix-cs).