Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-30319: Fixed ezrichtext.style.namespace parameter usage #30

Merged
merged 1 commit into from
Mar 18, 2019
Merged

EZP-30319: Fixed ezrichtext.style.namespace parameter usage #30

merged 1 commit into from
Mar 18, 2019

Conversation

SerheyDolgushev
Copy link
Contributor

@SerheyDolgushev SerheyDolgushev commented Mar 18, 2019 •
edited by alongosz
Loading

Question Answer
JIRA issue EZP-30319
Bug/Improvement yes
New feature no
Target version 1.0 for eZ Platform 2.4.x
BC breaks no
Tests pass yes
Doc needed no

We were trying to implement default templates for block/inline custom styles. Found them here, and debugged why they were not working properly.

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@lserwatka
Copy link
Member

@alongosz does it affect 1.0 branch too?

@lserwatka lserwatka requested a review from alongosz March 18, 2019 11:45
@andrerom
Copy link
Contributor

@lserwatka yes: https://github.com/ezsystems/ezplatform-richtext/blob/1.0/src/bundle/Resources/config/fieldtype_services.yml#L41

@alongosz alongosz changed the title Fixing ezrichtext.style.namespace parameter usage EZP-30319: Fixed ezrichtext.style.namespace parameter usage Mar 18, 2019
@alongosz alongosz added the Bug Something isn't working label Mar 18, 2019
@alongosz alongosz force-pushed the fix-style-configuration-namespace branch from 91e1530 to bdc625d Compare March 18, 2019 13:07
@alongosz alongosz changed the base branch from master to 1.0 March 18, 2019 13:07
alongosz
alongosz approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased to 1.0 and created JIRA issue.

@lserwatka lserwatka merged commit acce142 into ezsystems:1.0 Mar 18, 2019
@lserwatka
Copy link
Member

@alongosz could you merge it up?

@alongosz
Copy link
Member

Merged up to master.

Thank you @SerheyDolgushev 🎉

@lserwatka
Copy link
Member

We will make a 1.0.3 release.

@SerheyDolgushev
Copy link
Contributor Author

@alongosz our pleasure! :)
Sorry, I just checked JIRA ticket, and this fix will not solve the warning. But it will solve the error. So "Template style 'XXX' configuration was not found" warning will still be there.
(not sure if this note is very important)

@alongosz
Copy link
Member

Sorry, I just checked JIRA ticket, and this fix will not solve the warning. But it will solve the error. So "Template style 'XXX' configuration was not found" warning will still be there.

My mistake, but fortunately only in JIRA description.
There are two warnings, the first one is expected.
The second one not: app.WARNING: Template style 'XXX' default configuration was not found and it should disappear for you also (I hope). Fixed description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@alongosz alongosz alongosz approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SerheyDolgushev @lserwatka @andrerom @alongosz @adamwojs