EZP-31675: do not cast parameters part to string

[bdunogier]

Question	Answer
JIRA issue	EZP-31675
Type	bug
Target eZ Platform version	v2.x, v3.x
BC breaks	no
Tests pass	yes
Doc needed	no

Due to a string typehint in the Query Field Service, integer or boolean parameters always ended up as strings, causing errors in the Query Types options resolution.

Checklist:

• PR description is updated.
• Tests are implemented.
• Added code follows Coding Standards (use $ composer fix-cs).
• PR is ready for a review.

[Nattfarinn]

private function isExpression($expression): bool
{
    return is_string($expression) && substr($expression, 0, 2) !== '@=';
}

and:

foreach ($expressions as $key => $expression) {
    if (is_array($expression)) {
        $expressions[$key] = $this->resolveParameters($expression, $variables);
    } else if ($this->isExpression($expression)) {
        $expressions[$key] = $this->resolveExpression($expression, $variables);
    } else {
        $expressions[$key] = $expression;
    }
}

Would be a bit cleaner without removing typehint and we would avoid "do nothing path" of resolveExpression method.

[bdunogier]

Good idea, @Nattfarinn, thank you.

[bdunogier]

@Nattfarinn is it better now ?

[bdunogier]

Thank you for the review & review-request, @Nattfarinn.

[lserwatka]

@adamwojs could you merge it up?