[3.x][VCL] Update purge logic from FOS #118
Conversation
| @@ -127,32 +127,33 @@ sub ez_purge { | |||
| // Retrieve purge token, needs to be here due to restart, match for PURGE method done within | |||
| call ez_invalidate_token; | |||
There was a problem hiding this comment.
Not a regression from this PR, however the code in this subroutine will need to be adapted to also take into account req.method == "PURGEKEYS".
Ref: if (req.restarts == 0 && req.method == "PURGE" && req.http.x-invalidate-token) {
There was a problem hiding this comment.
Proposal for fix on that in e377e19
|
@andrerom What is the recommended way of switching between |
|
@micszo It's a FOSHttpCache config option, soft is used by default: https://foshttpcachebundle.readthedocs.io/en/latest/reference/configuration/proxy-client.html#tag-mode |
There was a problem hiding this comment.
Verified with sanities on eZ Platform EE master with Varnish 6.1 with softpurge and purge.
In fact resolves issues encountered earlier on v3 (#107 (comment)).
|
Nota bene, @mnocon aptly noticed that there also is https://github.com/ezsystems/ezplatform/blob/master/.platform/varnish.vcl. Will that one have to be adapted to these changes as well? |
not planned on my side, I'd suggest we find a way to drop it and use the one from here. Same with this btw: |
|
@micszo Changes for meta repo (update platform.sh VCL + remove the other one which was deprecated): ezsystems/ezplatform#505 |
masterUpdates VCL to be in sync with the purge logic from FOS.
This drops eZ specific Ban which was Varnish specific, and adds support for FOS capability to do hard tag purge.